feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE` #3504

eduardoboucas · 2021-10-14T13:15:13Z

- Summary

Loads Go functions by default without requiring the NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE environment variable to be set.

- Test plan

Adjusted existing test.

github-actions · 2021-10-14T13:15:51Z

📊 Benchmark results

Comparing with 0eea04d

Package size: 357 MB

(no change)

^  353 MB  353 MB  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  357 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (0eea04d): 357 MB
T-29 (a50e410): 357 MB
T-28 (759ff3a): 357 MB
T-27 (20e4fe1): 357 MB
T-26 (e9d43b7): 357 MB
T-25 (7af5fa0): 357 MB
T-24 (a32da85): 357 MB
T-23 (7f85116): 357 MB
T-22 (0ab6390): 357 MB
T-21 (5f1bf32): 357 MB
T-20 (10d053d): 357 MB
T-19 (a24dc84): 358 MB
T-18 (1aef852): 358 MB
T-17 (558d6ed): 358 MB
T-16 (6d6022e): 353 MB
T-15 (532a040): 353 MB
T-14 (82bd008): 353 MB
T-13 (8192dba): 353 MB
T-12 (95890b2): 353 MB
T-11 (0208c89): 353 MB
T-10 (7815bbb): 352 MB
T-9 (68fd362): 352 MB
T-8 (b6446af): 352 MB
T-7 (3e3c80a): 352 MB
T-6 (adae111): 352 MB
T-5 (76a9aa6): 352 MB
T-4 (e406f33): 352 MB
T-3 (4289e60): 352 MB
T-2 (1ebb1e7): 352 MB
T-1 (414bd99): 352 MB
T (current commit): 357 MB

feat: remove NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE

dc015da

eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 14, 2021

eduardoboucas requested a review from netlify-team-account-1 October 14, 2021 13:15

erezrokah approved these changes Oct 15, 2021

View reviewed changes

eduardoboucas added the automerge Add to Kodiak auto merge queue label Oct 15, 2021

Merge branch 'main' into feat/remove-go-feature-flag

b1afd73

kodiakhq bot merged commit f9cd6ba into main Oct 15, 2021

kodiakhq bot deleted the feat/remove-go-feature-flag branch October 15, 2021 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE` #3504

feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE` #3504

eduardoboucas commented Oct 14, 2021

github-actions bot commented Oct 14, 2021 •

edited

Loading

feat: remove NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE #3504

feat: remove NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE #3504

Conversation

eduardoboucas commented Oct 14, 2021

github-actions bot commented Oct 14, 2021 • edited Loading

📊 Benchmark results

Package size: 357 MB

feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE` #3504

feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE` #3504

github-actions bot commented Oct 14, 2021 •

edited

Loading